Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usages of deprecated React lifecycle methods #3317

Closed
Hypnosphi opened this issue Mar 29, 2018 · 0 comments
Closed

Remove usages of deprecated React lifecycle methods #3317

Hypnosphi opened this issue Mar 29, 2018 · 0 comments
Assignees
Labels
maintenance User-facing maintenance tasks

Comments

@Hypnosphi
Copy link
Member

Work summary

https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html
We need to add react-lifecycles-compat dependency to use new static getDerivedStateToProps method

Acceptance criteria

cWM, cWRP, and cWU shouldn't be used in our codebase.
Unfortunately, eslint-plugin-react doesn't have a rule for disabling particular methods (see discussion). So I'll need to check it manually. I'll also investigate how we could utilize StrictMode to detect violations.

Who to contact

Me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

No branches or pull requests

1 participant