Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addon-a11y uses React.Fragment without specifying react >=16.2.0 #3370

Closed
timothymclane opened this issue Apr 5, 2018 · 4 comments
Closed

Comments

@timothymclane
Copy link
Contributor

Bug or support request summary

Using @​storybook/addon-a11y with Storybook in a React 15 project throws errors as React.Fragment is undefined.

This can be fixed by specifying a minimum React version or removing the Fragment usage in ./components/Report. Given I have some React 15 projects using addon-a11y 3.4.0, I'd prefer removing it altogether.

I'd be happy to make a pull request to address the problem.

Steps to reproduce

  1. Start a new React v15 project (I used CRA and installed React and ReactDOM 15.4.0)
  2. add Storybook via getstorybook
  3. install and enable addon-a11y
  4. Storybook now errors in browser.

Repo with issue

Please specify which version of Storybook and optionally any affected addons that you're running

@​storybook/addon-a11y 3.4.0
@​storybook/react 3.4.0

Affected platforms

  • Impacts any project with a React version that doesn't support Fragments
@danielduan
Copy link
Member

danielduan commented Apr 5, 2018

@timothymclane that'd be great if you can remove them. you're welcome to create a PR.

We do still attempt to support React 15 for the time being.

@Hypnosphi
Copy link
Member

Yes, let's remove the Fragment usage

@timothymclane
Copy link
Contributor Author

Sounds good. I will get my environment set up and make that request.

@Hypnosphi
Copy link
Member

Released as 3.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants