Chromeless Support for Storyshots

[dan-kez]

Work summary

The ability to use a different headless chrome tool to take screenshots. Specifically, Chromeless due to it's lambda support.

I'm happy to help with this endeavor.

Where to start

https://github.com/prismagraphql/chromeless - Has good docs for their api. My assumption is that based on a config value storyshots could determine whether to run puppeteer locally or use chromeless.

Acceptance criteria

The ability to initiate storyshots with a chromeless config (API Key, etc) so that users can run their screenshots in lambda.

[danielduan]

If you can put together a PR, we'd be happy to take a look. Make sure you update our example Storybook to demonstrate and prove the functionality.

[igor-dv]

IMHO, image storyshots should've been separated to a separate addon (the shared code can be extracted, that's not a problem). Today when you want to bring addon-storyshots but use only regular snapshots you need to install all these puppeteer deps. I don't see how adding another headless browser thingy (even if it's useful) will simplify things here.

I think we need a refactoring that will bring some kind of separation like this:

• addon-storyshots - the initial loose storyshots api
• addon-storyshots-puppeteer-binding - extra api that brings puppeteer features
• addon-storyshots-chromeless-binding - extra api that brings chromeless features

[Hypnosphi]

Heavy plus one to @igor-dv.

If we're going to do that, right now is the best time as we're approaching major release
@igor-dv would you do the splitting of addon-storyshots-puppeteer-binding?

[igor-dv]

Yes. Will work on it 👍

[Hypnosphi]

Released as 4.0.0-alpha.10

[igor-dv]

This one was not releasd =)

[stale]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

[stale]

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

[dan-kez]

Just wanted to chime in here and say that a chromeless adapter may not be necessary given that has recently been deprecated.

Thank you for all the awesome work on this!