Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glamorous package is not maintained anymore, time to move to emotion #3689

Closed
leandrooriente opened this issue May 30, 2018 · 1 comment
Closed

Comments

@leandrooriente
Copy link
Contributor

glamorous package will not be maintained anymore, the recommendation is to move to emotion package.

Bug or support request summary

If you add new React Strict Mode Component as a global addon and withInfo storybook addon it throws a warning because withInfo uses glamorous who uses deprecated methods from React 16.3.0. glamorous maintainers will not fix the problem since it is not maintained anymore.

Steps to reproduce

config.js

import React, { StrictMode } from 'react';
import { addDecorator } from '@storybook/react';

const StrictModeDecorator = (storyFn) => (
  <StrictMode>
    {storyFn()}
  </StrictMode>
);

const req = require.context('../', true, /\.stories\.js$/);
const loadStories = () => req.keys().forEach(req);

addDecorator(StrictModeDecorator);

Example.stories.js

import React from 'react';
import { storiesOf } from '@storybook/react';
import { withInfo } from '@storybook/addon-info';

const Example = () => (
  <div>Test</div>
)

storiesOf('Example', module)
  .add('With intro description', withInfo(`
    #### Documentation title
  `)(() => (
    <Example />
  )));

Please specify which version of Storybook and optionally any affected addons that you're running

  • @storybook/react 3.4.2
  • @storybook/addon-info 3.4.6

Affected platforms

  • react 16.3.0

Screenshots / Screencast / Code Snippets (Optional)

screen shot 2018-05-30 at 16 18 12

@leandrooriente
Copy link
Contributor Author

Closing: #3572

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant