Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The webpack watch dosn't rebuild when I perform npm run storybook #371

Closed
qiangege opened this issue Aug 11, 2016 · 7 comments
Closed

The webpack watch dosn't rebuild when I perform npm run storybook #371

qiangege opened this issue Aug 11, 2016 · 7 comments
Labels

Comments

@qiangege
Copy link

qiangege commented Aug 11, 2016

this is my demo
here:https://github.com/qiangege/react-storybook-demo.git

first
I perform npm run storybook
now, I change content of the files in node_modules,the webpack can rebuild

then
I open another service, don't close npm run storybook, I perform npm install range-input-react or npm install. now , I change content of the files in node_modules,the webpack dosn't rebuild,

this question is very strange.
What should I do to solve this problem

@arunoda
Copy link
Member

arunoda commented Aug 11, 2016

You mean, when you install new NPM modules, storybook webpack cannot determine that. Is it?

@qiangege
Copy link
Author

qiangege commented Aug 11, 2016

step npm run storybook > npm install a modules > npm install b module > change a file (file in node_modules)
it's not rebuild the project webpack watch it's not working .
you can try it.

@arunoda arunoda added the bug label Aug 11, 2016
@arunoda
Copy link
Member

arunoda commented Aug 11, 2016

Okay. Got it. I know how to fix this.
Note: Use CRA's WatchMissingNodeModulesPlugin.

@abnerCrack
Copy link

@arunoda
The first, thinks for your project.it's very great
About this problem I have a suggestion
see that:
https://www.npmjs.com/package/npm-install-webpack-plugin
npm-install-webpack-plugin

@arunoda
Copy link
Member

arunoda commented Aug 15, 2016

@abnerCrack This plugin does too much.
We don't want to save NPM packages and others. We just need to detect changes.
The plugin I mentioned above would work fine for this usecase.

PRs welcome :)

@abnerCrack
Copy link

@arunoda TOT.ok~~~~

@arunoda
Copy link
Member

arunoda commented Sep 15, 2016

We've fix this (original issue by @qiangege) with the latest Storybook.
Reopen if that doesn't fix your issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants