Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub pages build doesn't load images #382

Closed
FarhadG opened this issue Aug 15, 2016 · 4 comments
Closed

GitHub pages build doesn't load images #382

FarhadG opened this issue Aug 15, 2016 · 4 comments
Labels

Comments

@FarhadG
Copy link

FarhadG commented Aug 15, 2016

I have the following npm script:

    "deploy-storybook": "storybook-to-ghpages",

which works flawlessly, where it builds and deploys to github pages, however, none of the images are loading (asset paths are incorrect). This works just fine in storybook's development cycle, however, when I build and deploy to github pages, the assets don't load.

Any ideas?

@arunoda
Copy link
Member

arunoda commented Aug 16, 2016

Yes. That's an issue with paths. We are going to fix this in upcoming days.
For now for your images, try to use relative paths if possible.

@arunoda arunoda closed this as completed Aug 16, 2016
@arunoda arunoda reopened this Aug 16, 2016
@arunoda arunoda added the bug label Aug 16, 2016
@FarhadG
Copy link
Author

FarhadG commented Aug 23, 2016

Thank you! Looking forward to this release :)

@arunoda
Copy link
Member

arunoda commented Aug 24, 2016

We did a fix for this with v2.4.2.
Give it a try.
It should fix your issues. (Only if you are using require(or import) to load images).
If you are using static directories, (via -s option) you must use relative URLs.

@arunoda
Copy link
Member

arunoda commented Aug 24, 2016

Reopen if this doesn't work for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants