Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@storybook/addon-backgrounds set background via name #4025

Closed
donaldpipowitch opened this issue Aug 16, 2018 · 2 comments
Closed

@storybook/addon-backgrounds set background via name #4025

donaldpipowitch opened this issue Aug 16, 2018 · 2 comments

Comments

@donaldpipowitch
Copy link
Contributor

Hi there,

we have some url(data:image/gif;base64,....) set as a possible background with @storybook/addon-backgrounds. We would like to enable this background in a storyshot test only and not as the default background. It seems like the URL can't be used correctly in the test because of encoding problems. While I try to figure out the encoding problem, I'd like to ask if it would be possible to set the background as a query param via the name field of the background. We always thought why this wasn't possible (because it would make the URL "nicer", easier to understand and manipulate manually), but this is the first time were it would also make some technical problem easier, so I thought I'd share the feature request.

The concrete URL is http://localhost:9001/?background=url%28data%3Aimage%2Fgif%3Bbase64%2CR0lGODlhEAAQAIAAAOXl5f%2F%2F%2FyH5BAAAAAAALAAAAAAQABAAAAIfjG%2Bgq4jM3IFLJgpswNly%2FXkcBpIiVaInlLJr9FZWAQA7%29.


I'm sorry for deleting the template, but I just couldn't think of a good way to fit this request in the given template in a way that it is still easy to read 🤔 It seemed more suited for bugs instead of feature requests.

@Hypnosphi
Copy link
Member

Released as 4.0.0-alpha.20

@donaldpipowitch
Copy link
Contributor Author

Thank you 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants