Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting Query Parameters to imageSnapshot configuration #4119

Closed
donaldpipowitch opened this issue Sep 5, 2018 · 1 comment
Closed

Comments

@donaldpipowitch
Copy link
Contributor

Work summary

@storybook/addon-storyshots-puppeteer allows us to set a storybookUrl configuration to imageSnapshot. This is documented here and can be found in the code here.

As you can see in the linked code there are query params which are appended to the storybookUrl automatically. This makes it impossible to add your own query params which is what I plan to do with #4081. (Use a different background for storyshots.)

Where to start

Start here and either

  • allow setting query params to storybookUrl and append your internal params in a smarter way or
  • add a new configuration field like storybookParams which are appended internally at the correct position

Acceptance criteria

It is possible to add custom query params to the imageSnapshot.

Who to contact

I don't know? :)

@igor-dv
Copy link
Member

igor-dv commented Sep 8, 2018

I have no idea how to add labels on phone, but this one is a good first issue 😝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants