Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Storybook to monorepo #742

Closed
shilman opened this issue Apr 2, 2017 · 8 comments
Closed

Migrate Storybook to monorepo #742

shilman opened this issue Apr 2, 2017 · 8 comments
Assignees
Milestone

Comments

@shilman
Copy link
Member

shilman commented Apr 2, 2017

Creating this issue to track the work you're doing on moving Storybook to a mono-repo (and the associated bookkeeping).

@shilman shilman added this to the v3.0.0 milestone Apr 2, 2017
@shilman
Copy link
Member Author

shilman commented Apr 2, 2017

@ndelangen I took a look at migrating issues to the mono-repo. Here's what I found:

  1. https://github.com/IQAndreas/github-issues-import - robust issue import script (see below)
  2. https://gist.github.com/jonmagic/5282384165e0f86ef105 - an experimental github API that's incrementally better (see below)
  3. https://github.com/google/github-issue-mover - the top search result, but only migrates individual issues so not useful

Tested out github-issues-import and it creates issues like this: shilman/import-issues-spike#1

This is better than nothing, but updates the issue/comment author and timestamp to the person who is running the script at the time the script is run. It also requires disabling two-factor authentication temporarily. I have not tested more complex features like migrating milestones/labels/etc. which are also supported.

The experimental API is incrementally better than this, because it preserves the timestamp. However, it does not preserve the author information, closed-at, etc. and requires modifying the issue importer.

@ndelangen
Copy link
Member

from github support email:

Note that this API doesn't currently allow you create issues as authored by other users, since that would be a security concern. It's something we're considering adding in the future by allowing users to opt-in to such imports, but I can't say when that will happen. For now, you could add that information in a short header/footer in the content you create (e.g., at the bottom of each issue and comment).

So in whatever way we move issues over, the issues will never retain the original author.

@shilman
Copy link
Member Author

shilman commented Apr 3, 2017

@ndelangen In that case, I think the github-issues-import is our best option. If we are going to put the mono repo in storybooks/react-storybook then the number of issues from the constellation repos should be relatively small. I'm happy to take care of that when the time comes.

@ndelangen
Copy link
Member

DONE!

@eddiemonge
Copy link
Contributor

More than a year in and this still makes me sad. Monorepos might make dev easier but definitely make support harder.

@ndelangen
Copy link
Member

How so?

@eddiemonge
Copy link
Contributor

Searching issues is almost impossible for specific add-ons now. Unless every single issue is tagged with the add-on then knowing what applies to what is hard to do. Even if it is tagged, searching will still most likely pull non-related things in.

@ndelangen
Copy link
Member

I see, that's a valid point. We try to label things as much and accurate as possible.

Do you have any suggestions what we could do to improve things?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants