Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Preserve component ("kind") order on HMR #7517

Closed
shilman opened this issue Jul 22, 2019 · 2 comments
Closed

Core: Preserve component ("kind") order on HMR #7517

shilman opened this issue Jul 22, 2019 · 2 comments
Labels
bug core
Milestone
5.3.x

Comments

@shilman
Copy link
Member

shilman commented Jul 22, 2019

When you edit a story name, it is possible for that story (and its component) to change position in the treeview if there is no story sort function.

This is due to the way HMR works. By default, Storybook sorts by load order, but this load order chan change with edits.

I think we to fix this problem as follows:

  • Keep an ordering on all "kinds" that we've seen
  • Sort on that kind order by default, load order within a kind
@shilman shilman added this to the 5.2.0 milestone Jul 22, 2019
@vkrol
Copy link
Contributor

vkrol commented Jul 31, 2019

Probably it is fixed in 5.2.0-alpha.31 #6439 (comment).

@shilman shilman added the todo label Jul 31, 2019
@shilman shilman modified the milestones: 5.2.0, 5.2.x Sep 23, 2019
@shilman shilman modified the milestones: 5.2.x, 5.3.x Jan 11, 2020
@shilman
Copy link
Member Author

shilman commented Jan 16, 2020

I think this was fixed in #9482

@shilman shilman closed this as completed Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
5.3.x
Development

No branches or pull requests
2 participants
@vkrol @shilman