Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when .shot file contains a story that isn't present #874

Closed
shilman opened this issue Apr 15, 2017 · 2 comments
Closed

Error when .shot file contains a story that isn't present #874

shilman opened this issue Apr 15, 2017 · 2 comments
Labels
addon: storyshots

Comments

@shilman
Copy link
Member

shilman commented Apr 15, 2017

Issue by AsaAyers
Friday Oct 28, 2016 at 17:02 GMT
Originally opened as storybook-eol/storyshots#47

As we saw in #34, Jest will complain if there are extra snapshots. It would be very helpful if Storyshots would do the same.

In one of my projects a story was removed in one PR, but we didn't run storyshots with -u. Now a few PRs later the .shots files picked up that change.
@shilman
Copy link
Member Author

shilman commented Apr 15, 2017

Comment by SpaceK33z
Tuesday Dec 27, 2016 at 18:28 GMT

This is no longer relevant since v3.0, since it now uses Jest for snapshotting.

@shilman
Copy link
Member Author

shilman commented May 12, 2017

Seems like this is fixed, so I'm closing for now. Please re-open if it's still a problem!

@shilman shilman closed this as completed May 12, 2017
This was referenced Jan 12, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
addon: storyshots
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shilman