Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to React@15.0.0 #89

Closed
antoinerey opened this issue Apr 8, 2016 · 5 comments
Closed

Upgrade to React@15.0.0 #89

antoinerey opened this issue Apr 8, 2016 · 5 comments

Comments

@antoinerey
Copy link

React@15.0.0 is now out. Could the peerDependencies be upgraded to reflect this ?

@karlguillotte
Copy link

@antoinerey Is React 15 working with Storybook for you?

I am getting: Error: Objects are not valid as a React child (found: object with keys {}). If you meant to render a collection of children, use an array instead or wrap the object using createFragment(object) from the React add-ons. Check the render method of bound.

For now, I will keep using React 14 as specified in peerDependencies.

Thanks!

@antoinerey
Copy link
Author

Yup. It works the same with both React 14 and 15. The only warning I have is the one about CSS unitless string value. See #84

PS: I'm using the Storybook 1.6.0

@karlguillotte
Copy link

Thanks @antoinerey! Discovered that the issue is related with recompose.

@arunoda
Copy link
Member

arunoda commented Apr 9, 2016

Updated peer-deps to React v15.0.0 and tested.

@arunoda
Copy link
Member

arunoda commented Apr 9, 2016

Hope we can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants