Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove special code for a11y, actions and links in @storybook/server #9741

Closed
3 tasks done
tmeasday opened this issue Feb 4, 2020 · 8 comments
Closed
3 tasks done

Comments

@tmeasday
Copy link
Member

tmeasday commented Feb 4, 2020

Ideally the user could use these addons in the "normal" way without @storybook/server needing to do anything. This might mean some tweaks about what the "normal" way is:

  • a11y - install the decorator globally by default (in a preset), ensure it is easy to enable or disable in a story with parameters.

  • links - install the decorator globally in the preset

  • actions - install the "event" decorator globally in a preset, ensure it is configurable via parameters (and a no-op by default).

@jonspalmer
Copy link
Contributor

@tmeasday Trying to understand what you are expecting in terms of "installing in the preset" are there examples of that approach?

@tmeasday
Copy link
Member Author

Looks like you figured it out (#9932) -- or is there more you need to know?

@jonspalmer
Copy link
Contributor

I think I figured it out in the other PRs. Thanks for the followup

@stale stale bot added the inactive label Mar 18, 2020
@storybookjs storybookjs deleted a comment from stale bot Mar 20, 2020
@stale stale bot removed the inactive label Mar 20, 2020
@tmeasday
Copy link
Member Author

Is this task now done?

@jonspalmer
Copy link
Contributor

I think we still want to merge it.

@shilman
Copy link
Member

shilman commented Mar 21, 2020

Merged. Actions with args should be a slam dunk to round this out.

@shilman
Copy link
Member

shilman commented Mar 23, 2020

Ta-da!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.0.0-alpha.28 containing PR #9931 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Mar 23, 2020
@shilman shilman reopened this Mar 23, 2020
@shilman shilman modified the milestones: 6.0, 6.0 server Mar 26, 2020
@shilman
Copy link
Member

shilman commented Mar 31, 2020

Olé!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.0.0-alpha.30 containing PR #9933 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants