-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove special code for a11y
, actions
and links
in @storybook/server
#9741
Comments
@tmeasday Trying to understand what you are expecting in terms of "installing in the preset" are there examples of that approach? |
Looks like you figured it out (#9932) -- or is there more you need to know? |
I think I figured it out in the other PRs. Thanks for the followup |
Is this task now done? |
I think we still want to merge it. |
Merged. Actions with args should be a slam dunk to round this out. |
Ta-da!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.0.0-alpha.28 containing PR #9931 that references this issue. Upgrade today to try it out! You can find this prerelease on the Closing this issue. Please re-open if you think there's still more to do. |
Olé!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.0.0-alpha.30 containing PR #9933 that references this issue. Upgrade today to try it out! You can find this prerelease on the Closing this issue. Please re-open if you think there's still more to do. |
Ideally the user could use these addons in the "normal" way without
@storybook/server
needing to do anything. This might mean some tweaks about what the "normal" way is:a11y
- install the decorator globally by default (in a preset), ensure it is easy to enable or disable in a story with parameters.links
- install the decorator globally in the presetactions
- install the "event" decorator globally in a preset, ensure it is configurable via parameters (and a no-op by default).The text was updated successfully, but these errors were encountered: