Storyshots snapshot generation for every knobs composition

[stereodenis]

Is your feature request related to a problem? Please describe.
Now storyshots doesn't generate snapshots for every knobs composition.

Describe the solution you'd like
Generate snapshots for every knobs composition

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Are you able to assist bring the feature to reality?
no

[stereodenis]

@shilman add knobs label please

[stale]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

[stereodenis]

this is not stale

[shilman]

@stereodenis do you want to pick this up?

[stereodenis]

@shilman could you give me a direction?

[shilman]

@stereodenis Yeah I'd be happy to. Want to jump on our Discord https://discord.gg/UUt2PJb

I'm pretty booked up for the next month or so until 6.0 is out, but I'd love to see this get into SB 6.1.

[osdiab]

I too am interested in this!

[osdiab]

I would assume that some knobs would be easy to exhaustively step through (finite ones like radios and selects), but some knobs are not so straightforward (unbounded numbers); and that the number of combinations would explode if you have a lot of knobs, however (5 knobs with 5 settings already makes over 3000 combinations). would definitely need to constrain what gets tested, likely manually

[stereodenis]

@osdiab 5 knobs with 5 settings generate 120 combinations

[osdiab]

Huh? It would be 5^5 permutations no? Which is far more than 120

[stereodenis]

not stale. waiting for v6

[shilman]

Hi gang, We’ve just released addon-controls in 6.0-beta!

Controls are portable, auto-generated knobs that are intended to replace addon-knobs long term.

• Controls README
• Migration instructions

Please upgrade and try them out today. Thanks for your help and support getting this stable for release!

[stereodenis]

@shilman what about React Native?

[shilman]

For anybody who is interested in Controls but don't know where to start, I've created a quick & dirty step-by-step walkthrough to go from a fresh CRA project to a working demo. Check it out:

=> Storybook Controls w/ CRA & TypeScript

There are also some "knobs to controls" migration docs in the Controls README:

=> How do I migrate from addon-knobs?

[shilman]

@stereodenis Storybook for RN is still catching up with Component Story Format (CSF). It might adopt controls someday, but no direct path from here to there until it supports CSF.

[chrisj-skinner]

@shilman I've been using controls with the latest V9 of Angular lately and having good progress 👍 Nice one on the CRA project.

[ZDerekh]

Isn't this feature must have to get proper coverage of the components? Correct me if I'm wrong, but this would give so much value either based on knobs or brand new controls. It's been so many threads already on this topic, and no one was resulting in a submitted PR or a draft.

[ybrodsky]

Any update on this?
Any way to do it?

If you have 10 stories and you manage to reduce it to just 1 by using knobs (or controls, whatever) you will see a coverage decresed. So you are forced to have 10x more code just to avoid losing coverage.

[shilman]

@ybrodsky rough proposal here https://docs.google.com/document/d/1MF1QZdMvJ-0mMxCuFXxgthkig5AZp2L6f4VGNIu03zc/edit?usp=sharing

[jorisw]

Just to chime in, I don't think we're looking for Storybook Combos per se.

We're looking for StoryShots to cover boolean and enum Control options.

This would automate 10x the coverage on the components, without having a Combo story, which is a feature with a different target audience.

[ndelangen]

The future of storyshots is the test-runner:
https://storybook.js.org/docs/react/writing-tests/test-runner#page-top

And use the play function for expectations:
https://storybook.js.org/docs/react/writing-stories/play-function#page-top

We will not be making any improvement / changes to storyshots.