Angular: Fix compodoc with spaces in workspace root #18140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to removing unnecessary overhead, this allows for spaces in the workspace root path.
☁️ Nx Cloud ReportCI is running/has finished running commands for commit ddce4c0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
@yannbf friendly ping. Could this be reviewed soon? |
shilman
changed the title
ndelangen
approved these changes
Jul 6, 2022
|
If CI gives the green light, this can be merged! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where running compodoc fails if there are spaces in the workspace path. Spaces are not handled properly for arbitrary arguments when using
shell: true. This partially reverts changes made in #16728. AFAICT, the original issue there was fixed by usingnpxand settingcwd. I am using macOS but I don't think this matters.Fixes compodoc/compodoc#1222 (I think)