From 80790c825f11efd977b6c359d5c10e9ddae0c1d0 Mon Sep 17 00:00:00 2001 From: Yann Braga Date: Mon, 6 Feb 2023 10:11:44 +0100 Subject: [PATCH] undo AST main.js check in validateConfigFile --- code/lib/core-common/package.json | 1 - .../src/utils/validate-configuration-files.ts | 9 --------- code/yarn.lock | 1 - 3 files changed, 11 deletions(-) diff --git a/code/lib/core-common/package.json b/code/lib/core-common/package.json index e2cbd44ce375..ba83296fd1b3 100644 --- a/code/lib/core-common/package.json +++ b/code/lib/core-common/package.json @@ -44,7 +44,6 @@ }, "dependencies": { "@babel/core": "^7.20.2", - "@storybook/csf-tools": "7.0.0-beta.43", "@storybook/node-logger": "7.0.0-beta.43", "@storybook/types": "7.0.0-beta.43", "@types/babel__core": "^7.1.20", diff --git a/code/lib/core-common/src/utils/validate-configuration-files.ts b/code/lib/core-common/src/utils/validate-configuration-files.ts index 56cd3533be8c..b0483cd37385 100644 --- a/code/lib/core-common/src/utils/validate-configuration-files.ts +++ b/code/lib/core-common/src/utils/validate-configuration-files.ts @@ -2,7 +2,6 @@ import { dedent } from 'ts-dedent'; import { promise as glob } from 'glob-promise'; import path from 'path'; import slash from 'slash'; -import { readConfig } from '@storybook/csf-tools'; import { once } from '@storybook/node-logger'; import { boost } from './interpret-files'; @@ -25,13 +24,5 @@ export async function validateConfigurationFiles(configDir: string) { No configuration files have been found in your configDir (${path.resolve(configDir)}). Storybook needs "main.js" file, please add it. `); - } else { - const main = await readConfig(mainConfigPath); - if (!main.hasDefaultExport) { - once.warn(dedent` - Your main.js is not using a default export, which is the recommended format. Please update it. - For more info: https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#esm-format-in-mainjs - `); - } } } diff --git a/code/yarn.lock b/code/yarn.lock index fd23cbfdb5f0..a159f249980a 100644 --- a/code/yarn.lock +++ b/code/yarn.lock @@ -6068,7 +6068,6 @@ __metadata: resolution: "@storybook/core-common@workspace:lib/core-common" dependencies: "@babel/core": ^7.20.2 - "@storybook/csf-tools": 7.0.0-beta.43 "@storybook/node-logger": 7.0.0-beta.43 "@storybook/types": 7.0.0-beta.43 "@types/babel__core": ^7.1.20