Don't serve index.html as a site index

[jeef3]

This switch prevents the static files from serving index.html as an index. This means you can still have a index.html file in your static path and it won't get served up as the application index. Fixes #99.

From the ExpressJS documentation: http://expressjs.com/en/api.html#express.static

Sends the specified directory index file. Set to false to disable directory indexing.

However, if the browser is navigated to (for example) http://localhost:9001/index.html then it will serve the index.html from the static path. This does not conflict with the application though as there is no application index.html file to serve anyway.

---

Another fix was to move the:

app.get('/', function (req, res) {
  res.send(getIndexHtml());
});

above the if (program.staticDir) { ... } call, but I believe this PR solves the problem more correctly.

[arunoda]

I have not aware of this switch. And I think this is the best way to deal with this.
Thanks a lot.
We will take this in.

[tdreyno]

This doesn't seem to apply to the static storybook build. When I run that, the storybook index.html is overwritten by the index.html in my static directory.

[jeef3]

@tdreyno I believe this PR was done before the static build stuff was completed. Probably best to raise as a new issue 👍

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 776cfa1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 1 target

• nx run-many -t build --parallel=3

---

Sent with 💌 from NxCloud.