Add React Developer Tools hook #104
Conversation
wyattdanger
force-pushed
the
add-react-devtools-hook
branch
from
bd30f0f to
9ae56d6
Compare
| @@ -3,6 +3,11 @@ export default function (headHtml) { | |||
| <!DOCTYPE html> | |||
| <html> | |||
| <head> | |||
| <script> | |||
| if (window.parent !== window) { | |||
There was a problem hiding this comment.
this might actually throw an exception if the parent isn't same-origin - can you test it on a cross-origin page first? you may need to add a try/catch, or some other check.
There was a problem hiding this comment.
I think that we can safely assume this will always be served from the same origin and the storybook, and we don't need to worry about that. In fact, we can also remove the window.parent !== window check
There was a problem hiding this comment.
Actually, this could be completely omitted and instead added to the head.html by Storybook users as needed as described here
There was a problem hiding this comment.
It should really be default behaviour: As React developers we expect the dev tools to "just work".
@wyattdanger Thank for doing the PR; saved me a job.
There was a problem hiding this comment.
@wyattdanger yes, we can do it with the head.html. As @rogchap said, this should be the default.
|
I think this is great. We'll take this in. |
Added a View wrapper with a key prop
Install addon as devDependency in Readme
|
View your CI Pipeline Execution ↗ for commit 9ae56d6.
☁️ Nx Cloud last updated this comment at |
Adds a hook to make Storybook play nicely with React Developer Tools.
Fixes #102