Add airbnb-js-shims to client-side JS

[wyattdanger]

This adds airbnb-js-shims to the admin js and the iframe js, which gets IE11 working for me, where it used to break on an Array.from

[arunoda]

Isn't this something babel does automatically? I like to know which code breaks this?
Babel load it from the corejs package.

Could you try updating core-js to the latest: 2.2.3 in your project and see whether it fixes this or not.

[ljharb]

Babel transpiles syntax, not API. Shims are still required, and these ones actively shim fewer things than babel-polyfill/core-js.

[arunoda]

@ljharb doen't add more overhead. I think we only need es6 shims in that case.
So, it seems like babel's core-js usage has a problem. So we may should open an issue on core-js repo.

In the meantime, let's add only es6-shim to the core.

[ljharb]

@arunoda es5-shim and es5-sham are still required for React to work in IE 8. No browser, even latest Chrome, complies with ES5, even.

[arunoda]

@ljharb I'm not sure whether we need to support browsers like IE8

No browser, even latest Chrome, complies with ES5, even.
What do you mean by this?

CC / @mnmtanish

[ljharb]

@arunoda the cost is tiny, and the benefits range from zero to very high, depending on users' browser support matrix.

As for ES5, there does not exist any version of any JS engine that fully complies with ES5. The failures are minimal at this point, but they exist, and using the shims ensures they are papered over.

[arunoda]

@ljharb I think we can go with this.
I'll take this.

[wyattdanger]

Rebased, conflicts resolved

[arunoda]

Awesome.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 40cd0ec. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 1 target

• nx run-many -t build --parallel=3

---

Sent with 💌 from NxCloud.