Support requireing from node #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thani-sh
force-pushed
the
fix-node-require
branch
2 times, most recently
from
2921a96 to
db4b51c
Compare
Wrap calls to browser only features to allow storybook module to be required from node. This can be used to build CLI tools.
thani-sh
force-pushed
the
fix-node-require
branch
from
db4b51c to
97f854f
Compare
|
This PR and #332 will allow developers to use stories with command line tools. |
| @@ -2,6 +2,7 @@ import UUID from 'uuid'; | |||
|
|
|||
| export default class ClientApi { | |||
| constructor({ pageBus, storyStore }) { | |||
| // pageBus can be null | |||
There was a problem hiding this comment.
Describe a bit more here why this can be null.
|
Done |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 076183b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap calls to browser only features to allow storybook module
to be required from node. This can be used to build CLI tools.