Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add react docgen info into React classes with the react-docgen babel plugin #557

Merged
merged 4 commits into from
Oct 21, 2016

Conversation

madushan1000
Copy link
Contributor

Generates propType docs for all react components used in stories at runtime using babel-plugin-react-docgen.
It also collects all the react propType docs to a global object named STORYBOOK_REACT_CLASSES.

@@ -0,0 +1,3 @@
/* globals window */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this filename as globals.js

@arunoda arunoda merged commit 4200f77 into master Oct 21, 2016
@arunoda arunoda deleted the docgen branch October 21, 2016 15:54
@arunoda arunoda changed the title Add a propType doc to all react components Add react docgen info into React classes with the react-docgen babel plugin Oct 21, 2016
@jeffijoe
Copy link

Is it possible to disable this? It's causing some of my stuff to break.

@arunoda
Copy link
Member

arunoda commented Oct 27, 2016

Could I know the problem you got? More info on the error?
And yes we should provide a way to stop it.

@jeffijoe
Copy link

It was a reference error, Sink is not defined where Sink was my component. I made a HoC of sorts that returns 2 components and it could apparently not deal with it.

@arunoda
Copy link
Member

arunoda commented Oct 27, 2016

@jeffijoe can I have a sample version of that class? We'll work on a way to turn this off or something similar.

Could you create an new issue with info?

@jeffijoe
Copy link

@arunoda done, #580

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants