Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display storybook version #559

Merged
merged 2 commits into from
Oct 27, 2016
Merged

display storybook version #559

merged 2 commits into from
Oct 27, 2016

Conversation

usulpro
Copy link
Member

@usulpro usulpro commented Oct 23, 2016

here it is #553

@@ -27,6 +27,8 @@ program
.option('--enable-db', 'DEPRECATED!')
.parse(process.argv);

logger.info(chalk.bold(`${packageJson.name} v${packageJson.version}`));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a new line to end of this line.

Copy link
Member

@arunoda arunoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this to the build.js in the same directory.
That's what's get invoked when you run npm run build-storybook.

@usulpro
Copy link
Member Author

usulpro commented Oct 25, 2016

Ok

@arunoda arunoda merged commit bc9e6ac into storybookjs:master Oct 27, 2016
@usulpro
Copy link
Member Author

usulpro commented Oct 27, 2016

Hi @arunoda
Is everything Ok with it? Just let me know if I need to fix something
I checked it under Windows:

start-storybook build-storybook
image image

It may be worth adding "start" and "build" between the name and version?

@arunoda
Copy link
Member

arunoda commented Oct 27, 2016

I just published a new version with the PR you sent.

I didn't get this part?

It may be worth adding "start" and "build" between the name and version?

@usulpro
Copy link
Member Author

usulpro commented Oct 27, 2016

I just wrote this in the same moment when you merged it and didn't see it :)
I think in general it should be clear what the command is executed. So it's not necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants