Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change brand name from “React Storybook” to “Storybook” #1044

Merged
merged 4 commits into from
May 17, 2017
Merged

Change brand name from “React Storybook” to “Storybook” #1044

merged 4 commits into from
May 17, 2017

Conversation

ndelangen
Copy link
Member

What I did

  • I moved and renamed storybooks
  • changed wording from "React Storybook" to "Storybook"

shilman
shilman requested changes May 17, 2017
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change unrelated to your change, but on the same line.

addons/storyshots/README.md Outdated
@@ -21,7 +21,7 @@ To use StoryShots, you must use your existing Storybook stories as the input for
Add the following module into your app.

```sh
npm install -save-dev storyshots
npm install -save-dev @storybook/addon-storyshots
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be --save-dev?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, can you approve now?

@usulpro
Copy link
Member

usulpro commented May 17, 2017

So we officialy rename React Storybook to Storybook?

seems logical 👍
the only doubt how will this affect the indexing in web search?
compare react storybook vs storybook

@ndelangen
Copy link
Member Author

It's still the top hit? I see no problem with this.

It's a needed step.

@ndelangen ndelangen merged commit cf4f080 into master May 17, 2017
@ndelangen ndelangen deleted the restructure-storyshots branch May 17, 2017 15:49
@shilman shilman mentioned this pull request May 18, 2017
Merged
@shilman shilman added the misc label May 27, 2017
@ndelangen ndelangen changed the title MOVE & RENAME and storyshots && CHANGE “React Storybook” > “Storybook” Change brand name from “React Storybook” to “Storybook” May 27, 2017
@dependencies dependencies bot mentioned this pull request Nov 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman requested changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndelangen @usulpro @shilman