Add react-dom to the devDependency list for React Native projects #1102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Closes #1099
What I did
I have added a check to see if
react-dom
isn't already in either thedependencies
ordevDependencies
of the React Native project whengetstorybook
is run. If it isn't, it will add it to thedevDependencies
of thepackage.json
.How to test
Testing adding
react-dom
as a dependency.getstorybook
.yarn run storybook
should run without further steps.Testing ignoring
react-dom
as a dependency.getstorybook
.yarn run storybook
should run without further steps and thereact-dom
dependency should not have been touched.