Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add react-dom to the devDependency list for React Native projects #1102

Merged

Conversation

matt-oakes
Copy link
Contributor

Issue: Closes #1099

What I did

I have added a check to see if react-dom isn't already in either the dependencies or devDependencies of the React Native project when getstorybook is run. If it isn't, it will add it to the devDependencies of the package.json.

How to test

Testing adding

  1. Create a React Native project without react-dom as a dependency.
  2. Run getstorybook.
  3. yarn run storybook should run without further steps.

Testing ignoring

  1. Create a React Native project with react-dom as a dependency.
  2. Run getstorybook.
  3. yarn run storybook should run without further steps and the react-dom dependency should not have been touched.

@ndelangen ndelangen merged commit fa3d19d into storybookjs:master May 23, 2017
@shilman shilman added the misc label May 27, 2017
@ndelangen ndelangen added maintenance User-facing maintenance tasks react-native labels May 27, 2017
@matt-oakes matt-oakes deleted the issue-1099-react-native-react-dom branch July 5, 2017 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks react-native
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants