Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add events addon #1130

Merged
merged 26 commits into from
Jun 7, 2017
Merged

Add events addon #1130

merged 26 commits into from
Jun 7, 2017

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented May 25, 2017

What I did

I added the events addon create by @z4o4z to this repository.
original repository here: https://github.com/z4o4z/storybook-addon-events

How to test

  • run the cra-storybook example

@ndelangen ndelangen added the maintenance User-facing maintenance tasks label May 25, 2017
@ndelangen ndelangen added this to the v3.1.0 milestone May 25, 2017
@ndelangen ndelangen requested review from benediktvaldez and z4o4z May 25, 2017 21:20
@codecov
Copy link

codecov bot commented May 25, 2017

Codecov Report

Merging #1130 into master will decrease coverage by 0.38%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1130      +/-   ##
==========================================
- Coverage   12.85%   12.47%   -0.39%     
==========================================
  Files         199      209      +10     
  Lines        4503     4641     +138     
  Branches      715      731      +16     
==========================================
  Hits          579      579              
- Misses       3291     3413     +122     
- Partials      633      649      +16
Impacted Files Coverage Δ
addons/events/src/preview.js 0% <0%> (ø)
addons/events/src/index.js 0% <0%> (ø)
addons/events/register.js 0% <0%> (ø)
addons/events/stories/components/Logger.js 0% <0%> (ø)
addons/events/src/components/Event.js 0% <0%> (ø)
addons/events/stories/index.js 0% <0%> (ø)
addons/events/stories/constants.js 0% <0%> (ø)
addons/events/src/constants.js 0% <0%> (ø)
addons/events/src/manager.js 0% <0%> (ø)
addons/events/src/components/Panel.js 0% <0%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe66b26...24fb450. Read the comment docs.

@ndelangen
Copy link
Member Author

@z4o4z care to review?

Copy link
Member

@z4o4z z4o4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix it ASAP

@codecov
Copy link

codecov bot commented May 26, 2017

Codecov Report

Merging #1130 into master will decrease coverage by 0.35%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1130      +/-   ##
==========================================
- Coverage   14.07%   13.71%   -0.36%     
==========================================
  Files         200      207       +7     
  Lines        4497     4615     +118     
  Branches      506      634     +128     
==========================================
  Hits          633      633              
+ Misses       3436     3432       -4     
- Partials      428      550     +122
Impacted Files Coverage Δ
addons/events/src/manager.js 0% <0%> (ø)
addons/events/src/components/Event.js 0% <0%> (ø)
addons/events/src/components/Panel.js 0% <0%> (ø)
addons/events/register.js 0% <0%> (ø)
addons/events/src/preview.js 0% <0%> (ø)
addons/events/src/constants.js 0% <0%> (ø)
addons/events/src/index.js 0% <0%> (ø)
addons/knobs/src/KnobManager.js 38.57% <0%> (ø) ⬆️
.../src/manager/containers/CommentsPanel/dataStore.js 34.78% <0%> (ø) ⬆️
...codemod/src/transforms/update-organisation-name.js 40.62% <0%> (ø) ⬆️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67d6af3...8216f66. Read the comment docs.

@ndelangen ndelangen modified the milestones: v3.0.2, v3.1.0 Jun 6, 2017
@ndelangen ndelangen merged commit 9e8abd5 into master Jun 7, 2017
@ndelangen ndelangen deleted the add-events-addon branch June 7, 2017 05:29
@shilman shilman added feature request and removed maintenance User-facing maintenance tasks labels Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants