Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

start-storybook cli - expand commands descriptions #1161

Merged
merged 3 commits into from
May 30, 2017
Merged

start-storybook cli - expand commands descriptions #1161

merged 3 commits into from
May 30, 2017

Conversation

ArtyomResh
Copy link
Contributor

Issue:
The description of the CLI commands was incomplete

What I did

Expand it

How to test

Just check it

@ArtyomResh ArtyomResh mentioned this pull request May 30, 2017
Closed
@codecov
Copy link

codecov bot commented May 30, 2017 •
edited
Loading

Codecov Report

Merging #1161 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1161   +/-   ##
=======================================
  Coverage   12.72%   12.72%           
=======================================
  Files         199      199           
  Lines        4582     4582           
  Branches      727      727           
=======================================
  Hits          583      583           
  Misses       3356     3356           
  Partials      643      643

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 472bb08...b36a02b. Read the comment docs.

@ndelangen
Copy link
Member

Hey @ArtyomResh thank you for adding this, every contribution helps!

If you see any more problems or missing info in the docs, please make another PR, very much appreciated! Don't be afraid to propose bigger changes to the docs, we know they are needed and would love your input!

@ndelangen ndelangen merged commit 388ce35 into storybookjs:master May 30, 2017
@ndelangen ndelangen changed the title fix(cli-options/index.md): expand commands descriptions expand commands descriptions May 30, 2017
@ndelangen ndelangen changed the title expand commands descriptions start-storybook cli - expand commands descriptions May 30, 2017
@shilman
Copy link
Member

shilman commented May 30, 2017

Thanks!!! 🙏 @ArtyomResh

@ArtyomResh
Copy link
Contributor Author

You are welcome ;)

@ndelangen ndelangen added this to the v3.0.1 milestone Jun 2, 2017
@ndelangen ndelangen added the cli label Jun 2, 2017
@dependencies dependencies bot mentioned this pull request Nov 11, 2017
Merged
This was referenced Feb 1, 2022
Merged
Closed
This was referenced Jul 4, 2023
Open
Open
This was referenced Aug 12, 2023
Open
Open
@lili2311 lili2311 mentioned this pull request Sep 22, 2023
Open
This was referenced Nov 25, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

Assignees
No one assigned
Labels
cli documentation
Projects
None yet
Milestone
v3.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@ArtyomResh @ndelangen @shilman