Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added error message for addon-options when used in RN incorrectly #1194

Merged
merged 1 commit into from
Jun 5, 2017

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Jun 5, 2017

Issue: You can't really use addon-options with RN, unless you put in a setTimeout.

See #1192 and #815

What I did

Made the error message a little bit more useful:
screenshot 2017-06-05 15 49 03

How to test

Not easy right now unfortunately. We need to fix #1012 :/

You can try using the options addon with a RN project, and file:// linking this version in to see the better error. See #815 for a repro of the original problem.

@tmeasday tmeasday requested a review from shilman June 5, 2017 05:52
@codecov
Copy link

codecov bot commented Jun 5, 2017

Codecov Report

Merging #1194 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1194      +/-   ##
==========================================
- Coverage   13.31%   13.31%   -0.01%     
==========================================
  Files         199      199              
  Lines        4588     4589       +1     
  Branches      525      663     +138     
==========================================
  Hits          611      611              
+ Misses       3518     3387     -131     
- Partials      459      591     +132
Impacted Files Coverage Δ
addons/options/src/preview/index.js 0% <0%> (ø) ⬆️
app/react/src/client/preview/error_display.js 0% <0%> (ø) ⬆️
addons/info/src/components/PropVal.js 0% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-build.js 0% <0%> (ø) ⬆️
...src/server/config/WatchMissingNodeModulesPlugin.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Number.js 7.14% <0%> (ø) ⬆️
addons/knobs/src/components/types/Color.js 6.34% <0%> (ø) ⬆️
...react-native/src/manager/components/PreviewHelp.js 0% <0%> (ø) ⬆️
addons/info/src/components/PropTable.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/init_panels.js 25% <0%> (ø) ⬆️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3368e8...f000df0. Read the comment docs.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman merged commit b6c40e5 into master Jun 5, 2017
@ndelangen ndelangen added this to the v3.0.2 milestone Jun 7, 2017
@ndelangen ndelangen changed the title Added error message for addon-options Added error message for addon-options when used in RN incorrectly Jun 7, 2017
@Hypnosphi Hypnosphi deleted the options-error-message branch August 17, 2017 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants