-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update marksy
dependecy due broken 1.1.0 version
#1204
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1204 +/- ##
=======================================
Coverage 13.31% 13.31%
=======================================
Files 199 199
Lines 4589 4589
Branches 536 531 -5
=======================================
Hits 611 611
- Misses 3502 3514 +12
+ Partials 476 464 -12
Continue to review full report at Codecov.
|
Thank you @nezed ! |
ndelangen
approved these changes
Jun 6, 2017
ndelangen
changed the title
Bug: Update
Update Jun 7, 2017
marksy
dependecy due broken 1.1.0 versionmarksy
dependecy due broken 1.1.0 version
nezed
added a commit
to kupibilet-frontend/ui
that referenced
this pull request
Jun 9, 2017
This was referenced Apr 12, 2021
This was referenced Apr 26, 2021
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important issue:
Current
addon-info
dependecymarksy: ^1.0.1
resolves as1.1.0
which brings to Storybook an errorThis error leads to #163 issue with confusing answer, because
marksy
already switched fromPrism
toHiglightJS
in version2.0.0
(See storybookjs/marksy#11)
There is no breaking changes betwen
1.1.0
and2.0.0
versions ofmarksy
What I did
Updated
marksy
dependecy version for@storybook/addon-info
How to test
Write any story description that can lead to markdown parsing.
My case is: