-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for vue in addon-notes #1278
Conversation
Wow, It looks elegant to me. ✨ |
This approach will cause a long term growth of this addon. In other words: We should continue looking for a method so this addon does not have any react or vue specific code at all. Probably the usage needs to change for that. |
Ok I'll figure out sth else |
Codecov Report
@@ Coverage Diff @@
## add-app-vue #1278 +/- ##
===============================================
- Coverage 14.53% 14.33% -0.21%
===============================================
Files 237 238 +1
Lines 4897 4931 +34
Branches 698 699 +1
===============================================
- Hits 712 707 -5
- Misses 3597 3620 +23
- Partials 588 604 +16
Continue to review full report at Codecov.
|
Issue:
What I did
I handled the vue components with addon notes
How to test
yarn install && yarn bootstrap --npm-client=yarn
cd examples/vue
yarn storybook
To DO