Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for vue in addon-notes #1278

Merged
merged 4 commits into from
Jun 14, 2017
Merged

Add support for vue in addon-notes #1278

merged 4 commits into from
Jun 14, 2017

Conversation

alexandrebodin
Copy link
Contributor

@alexandrebodin alexandrebodin commented Jun 14, 2017

Issue:

What I did

I handled the vue components with addon notes

How to test

yarn install && yarn bootstrap --npm-client=yarn
cd examples/vue
yarn storybook

To DO

  • A cleaner import

@kazupon
Copy link
Member

kazupon commented Jun 14, 2017

Wow, It looks elegant to me. ✨

@ndelangen
Copy link
Member

This approach will cause a long term growth of this addon.
We should be able to add a piece of markdown to story in question via this addon that is library agnostic.

In other words: We should continue looking for a method so this addon does not have any react or vue specific code at all.

Probably the usage needs to change for that.

@alexandrebodin
Copy link
Contributor Author

Ok I'll figure out sth else

@codecov
Copy link

codecov bot commented Jun 14, 2017

Codecov Report

Merging #1278 into add-app-vue will decrease coverage by 0.2%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           add-app-vue    #1278      +/-   ##
===============================================
- Coverage        14.53%   14.33%   -0.21%     
===============================================
  Files              237      238       +1     
  Lines             4897     4931      +34     
  Branches           698      699       +1     
===============================================
- Hits               712      707       -5     
- Misses            3597     3620      +23     
- Partials           588      604      +16
Impacted Files Coverage Δ
app/vue/src/client/preview/render.js 0% <ø> (ø) ⬆️
app/vue/src/client/preview/client_api.js 86.84% <ø> (+2.39%) ⬆️
addons/notes/src/react.js 0% <0%> (ø)
addons/notes/src/index.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Boolean.js 11.62% <0%> (ø) ⬆️
addons/storyshots/src/test-bodies.js 0% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-start.js 0% <0%> (ø) ⬆️
.../src/manager/containers/CommentsPanel/dataStore.js 34.78% <0%> (ø) ⬆️
addons/knobs/src/components/types/Select.js 7.93% <0%> (ø) ⬆️
...react-native/src/manager/components/PreviewHelp.js 0% <0%> (ø) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 385611b...5a6472d. Read the comment docs.

@ndelangen ndelangen merged commit a93eba3 into add-app-vue Jun 14, 2017
@ndelangen ndelangen deleted the addon-notes-vue branch June 14, 2017 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants