Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created CRA kitchen sink addons example #1288

Merged
merged 3 commits into from
Jun 15, 2017
Merged

Conversation

shilman
Copy link
Member

@shilman shilman commented Jun 15, 2017

Issue: #1220

What I did

The work with RN apps got too complicated, so I just started over:

  • renamed example to cra-kitchen-sink
  • added simple info, notes, centered, knobs examples
  • minor cleanup

How to test

npm install && npm run bootstrap
cd examples/cra-kitchen-sink
npm run storybook

- renamed project
- added `info`, `notes`, `centered`, `knobs` examples
@shilman shilman added maintenance User-facing maintenance tasks in progress labels Jun 15, 2017
@shilman shilman requested review from tmeasday and ndelangen June 15, 2017 05:14
@shilman shilman changed the title Redo CRA kitchen sink work in a single commit Redo CRA kitchen sink work from scratch Jun 15, 2017
@codecov
Copy link

codecov bot commented Jun 15, 2017

Codecov Report

Merging #1288 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #1288    +/-   ##
========================================
  Coverage   13.71%   13.71%            
========================================
  Files         207      207            
  Lines        4646     4646            
  Branches      529      637   +108     
========================================
  Hits          637      637            
+ Misses       3543     3464    -79     
- Partials      466      545    +79
Impacted Files Coverage Δ
app/react/src/server/babel_config.js 44.82% <0%> (ø) ⬆️
app/react/src/server/iframe.html.js 0% <0%> (ø) ⬆️
app/react-native/src/preview/story_kind.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Boolean.js 11.62% <0%> (ø) ⬆️
lib/ui/src/modules/shortcuts/actions/shortcuts.js 6.25% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_keyevents.js 33.33% <0%> (ø) ⬆️
...codemod/src/transforms/update-organisation-name.js 40.62% <0%> (ø) ⬆️
addons/knobs/src/components/PropField.js 10.86% <0%> (ø) ⬆️
lib/ui/src/modules/api/actions/api.js 49.42% <0%> (ø) ⬆️
addons/info/src/components/PropTable.js 0% <0%> (ø) ⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f64f5b7...aaa6e5b. Read the comment docs.

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@shilman shilman merged commit 23c3902 into master Jun 15, 2017
@ndelangen ndelangen deleted the 1220-cra-kitchensink-reboot branch June 16, 2017 06:38
@ndelangen
Copy link
Member

🎈

@shilman shilman changed the title Redo CRA kitchen sink work from scratch Created CRA kitchen sink addons example Jun 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants