Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed addon knobs proptypes deserialization #1290

Merged
merged 8 commits into from
Jun 17, 2017

Conversation

Gongreg
Copy link
Member

@Gongreg Gongreg commented Jun 15, 2017

Issue: #1265

What I did

Fixed proptype.
Deserialization doesn't return array anymore.

How to test

https://github.com/jkempff/storybook-addon-knobs-proptypes-issue .

Gongreg added 2 commits June 15, 2017 17:01
Deserializing now doesn't return array anymore.
@codecov
Copy link

codecov bot commented Jun 15, 2017

Codecov Report

Merging #1290 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #1290    +/-   ##
========================================
  Coverage   13.76%   13.76%            
========================================
  Files         201      201            
  Lines        4620     4620            
  Branches      501      609   +108     
========================================
  Hits          636      636            
+ Misses       3545     3456    -89     
- Partials      439      528    +89
Impacted Files Coverage Δ
addons/knobs/src/components/types/Date/index.js 72.72% <ø> (ø) ⬆️
addons/knobs/src/components/types/Array.js 80% <ø> (ø) ⬆️
addons/knobs/src/components/types/Object.js 5.81% <0%> (ø) ⬆️
addons/knobs/src/components/types/Boolean.js 11.62% <100%> (ø) ⬆️
addons/info/src/components/Node.js 0% <0%> (ø) ⬆️
addons/events/src/components/Event.js 0% <0%> (ø) ⬆️
...rc/modules/ui/components/left_panel/text_filter.js 33.33% <0%> (ø) ⬆️
addons/info/src/components/PropVal.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Number.js 8.06% <0%> (ø) ⬆️
addons/knobs/src/components/types/Select.js 7.93% <0%> (ø) ⬆️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3b0636...db5b5a6. Read the comment docs.

@shilman
Copy link
Member

shilman commented Jun 15, 2017

@Gongreg would you mind adding some examples to the examples/cra-kitchen-sink project to test this out?

@Gongreg
Copy link
Member Author

Gongreg commented Jun 16, 2017

@shilman, is the example project created by user is not enough? :)

@shilman
Copy link
Member

shilman commented Jun 16, 2017

@Gongreg if it's checked in we can test it automatically in the near future

@Gongreg
Copy link
Member Author

Gongreg commented Jun 16, 2017

@shilman, ah, makes sense, I will just not be able to do that in the next few days.

@shilman
Copy link
Member

shilman commented Jun 16, 2017

@Gongreg OK I'll just add it and merge then

@shilman shilman changed the title #1265 addon knobs proptypes deserialization Fix addon knobs proptypes deserialization Jun 17, 2017
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman merged commit 29cc9d8 into master Jun 17, 2017
@shilman shilman changed the title Fix addon knobs proptypes deserialization Fixed addon knobs proptypes deserialization Jun 17, 2017
@Hypnosphi Hypnosphi deleted the #1265-addon-knobs-proptypes-deserialization branch August 17, 2017 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants