-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed addon knobs proptypes deserialization #1290
Conversation
Deserializing now doesn't return array anymore.
Codecov Report
@@ Coverage Diff @@
## master #1290 +/- ##
========================================
Coverage 13.76% 13.76%
========================================
Files 201 201
Lines 4620 4620
Branches 501 609 +108
========================================
Hits 636 636
+ Misses 3545 3456 -89
- Partials 439 528 +89
Continue to review full report at Codecov.
|
@Gongreg would you mind adding some examples to the |
@shilman, is the example project created by user is not enough? :) |
@Gongreg if it's checked in we can test it automatically in the near future |
@shilman, ah, makes sense, I will just not be able to do that in the next few days. |
@Gongreg OK I'll just add it and merge then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Issue: #1265
What I did
Fixed proptype.
Deserialization doesn't return array anymore.
How to test
https://github.com/jkempff/storybook-addon-knobs-proptypes-issue .