Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lint-staged to the latest version 🚀 #1315

Merged
merged 2 commits into from
Jun 23, 2017

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Jun 18, 2017

Version 4.0.0 of lint-staged just got published.

Dependency lint-staged
Current Version 3.6.1
Type devDependency

The version 4.0.0 is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of lint-staged.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.


Release Notes v4.0.0

<a name"4.0.0">

4.0.0 (2017-06-18)

Bug Fixes

Breaking Changes

This might affect existing setups which depend on the -- argument.
(ad265664)

Commits

The new version differs by 5 commits.

  • ad26566 fix: Skip '--' argument for non-npm commands (#196)
  • 48fbe20 docs: Fix indentation (#197)
  • 2bcbc5f docs: Add link to referenced issue in README (#193)
  • 1345a0a chore: Set Jest env to node to avoid jsdom overhead (#189)
  • 3f9517e chore(eslint): Set ESLint environment to use Jest instead of Mocha (#190)

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

@codecov
Copy link

codecov bot commented Jun 18, 2017

Codecov Report

Merging #1315 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1315      +/-   ##
==========================================
+ Coverage   13.76%   13.76%   +<.01%     
==========================================
  Files         202      201       -1     
  Lines        4621     4620       -1     
  Branches      506      614     +108     
==========================================
  Hits          636      636              
+ Misses       3559     3462      -97     
- Partials      426      522      +96
Impacted Files Coverage Δ
...codemod/src/transforms/update-organisation-name.js 40.62% <0%> (ø) ⬆️
addons/info/src/components/Props.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/libs/filters.js 41.66% <0%> (ø) ⬆️
addons/info/src/components/markdown/code.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/PropForm.js 8.51% <0%> (ø) ⬆️
app/react/src/server/build.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Color.js 8% <0%> (ø) ⬆️
...react-native/src/manager/components/PreviewHelp.js 0% <0%> (ø) ⬆️
addons/info/src/components/Node.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_routing.js 28.94% <0%> (ø) ⬆️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6696fe2...a2e76c5. Read the comment docs.

@ndelangen ndelangen self-assigned this Jun 19, 2017
@ndelangen
Copy link
Member

I'll test this locally, and merge is succesfull

@shilman
Copy link
Member

shilman commented Jun 23, 2017

@ndelangen FYI this is causing bithound to fail

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants