Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove typescript typings for @storybook/addon-knobs #1339

Merged

Conversation

joscha
Copy link
Member

@joscha joscha commented Jun 22, 2017

@joscha joscha requested a review from ndelangen June 22, 2017 17:35
@codecov
Copy link

codecov bot commented Jun 22, 2017

Codecov Report

Merging #1339 into release/3.2 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/3.2    #1339   +/-   ##
============================================
  Coverage        13.76%   13.76%           
============================================
  Files              202      202           
  Lines             4621     4621           
  Branches           598      501   -97     
============================================
  Hits               636      636           
- Misses            3473     3553   +80     
+ Partials           512      432   -80
Impacted Files Coverage Δ
app/react/src/client/preview/reducer.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/shortcuts/actions/shortcuts.js 6.25% <0%> (ø) ⬆️
addons/info/src/components/Node.js 0% <0%> (ø) ⬆️
addons/info/src/components/PropTable.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/init_panels.js 25% <0%> (ø) ⬆️
addons/knobs/src/components/types/Object.js 5.81% <0%> (ø) ⬆️
app/react/src/server/babel_config.js 44.82% <0%> (ø) ⬆️
addons/storyshots/src/storybook-channel-mock.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/routes.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_keyevents.js 33.33% <0%> (ø) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf6faea...dcae32f. Read the comment docs.

@joscha joscha mentioned this pull request Jun 22, 2017
2 tasks
@joscha joscha changed the base branch from master to release/3.2 June 23, 2017 09:02
@joscha
Copy link
Member Author

joscha commented Jun 23, 2017

@shilman changed the base here as well.

@joscha joscha added this to the v3.2.0 milestone Jun 23, 2017
@joscha
Copy link
Member Author

joscha commented Jun 23, 2017

The DefinitelyTyped package has been released, can I merge this into the 3.2 branch @ndelangen @shilman?

@shilman shilman merged commit 11dc35d into storybookjs:release/3.2 Jun 23, 2017
@joscha joscha deleted the joscha/remove-addon-knobs-types branch June 23, 2017 23:19
@shilman shilman changed the title remove typings for @storybook/addon-knobs Remove typescript typings for @storybook/addon-knobs Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants