Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add state-setting FAQ #1559

Merged
merged 2 commits into from
Jul 31, 2017
Merged

Add state-setting FAQ #1559

merged 2 commits into from
Jul 31, 2017

Conversation

shilman
Copy link
Member

@shilman shilman commented Jul 31, 2017

Issue: N/A

What I did

Document a pattern for setting react state in stories

How to test

N/A

@shilman shilman requested review from tmeasday and ndelangen July 31, 2017 21:08
@codecov
Copy link

codecov bot commented Jul 31, 2017

Codecov Report

Merging #1559 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1559   +/-   ##
=======================================
  Coverage   20.46%   20.46%           
=======================================
  Files         241      241           
  Lines        5243     5243           
  Branches      645      648    +3     
=======================================
  Hits         1073     1073           
+ Misses       3673     3670    -3     
- Partials      497      500    +3
Impacted Files Coverage Δ
addons/knobs/src/components/PropForm.js 8.51% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-build.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_routing.js 28.94% <0%> (ø) ⬆️
lib/ui/src/modules/api/actions/api.js 49.42% <0%> (ø) ⬆️
...react-native/src/manager/components/PreviewHelp.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_keyevents.js 33.33% <0%> (ø) ⬆️
.../src/manager/containers/CommentsPanel/dataStore.js 34.78% <0%> (ø) ⬆️
addons/events/src/components/Event.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Select.js 7.81% <0%> (ø) ⬆️
addons/knobs/src/components/types/Object.js 5.81% <0%> (ø) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22fad69...6395881. Read the comment docs.

@shilman shilman merged commit e3bcd4d into master Jul 31, 2017
@shilman shilman deleted the faq-component-state branch July 31, 2017 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants