[Info Addon] Enable many components of same type in prop tables #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prop Tables were being key'd by their component's object `name` prop; this means that only the first component, of many components of the same type, would show. Making sure we first check `displayName` for key usage means that components with the same type can all appear in the Prop Tables if their individual `displayName`'s were different. Case: Higher Order Components
loklaan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Could not show components in Prop Tables if they had the same
type.nameprop.What I did
Use the
displayNameas a key for the Prop Tables instead.More
Case: Higher Order Components
Previously the keying of Tables was done with the
nameprop of the component type. This inadvertently filtered out all other components that had the samenamevalue. eg Higher Order Components.Making sure we first check
displayNamefor key usage means that components with the same type can all appear in the Prop Tables, if their individualdisplayName's are different.