-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added addon-knobs to crna and vanilla react native. #1636
Conversation
I don't reckon the duplication is an issue! Can you update the snapshot? Should be a matter of running |
@tmeasday, alright, I'll do it tomorrow. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look good to me. The duplication errors are there to help us find redundant code, but this should probably be duplicated.
I fixed a merge-conflict in the package.json |
Codecov Report
@@ Coverage Diff @@
## release/3.3 #1636 +/- ##
============================================
Coverage 21.24% 21.24%
============================================
Files 252 252
Lines 5695 5695
Branches 683 687 +4
============================================
Hits 1210 1210
+ Misses 3958 3938 -20
- Partials 527 547 +20
Continue to review full report at Codecov.
|
TESTED |
Issue: rn examples were missing addon knobs examples.
What I did
Added example taken from cra example.
How to test
Try it out.