Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added addon-knobs to crna and vanilla react native. #1636

Merged
merged 8 commits into from
Aug 26, 2017

Conversation

Gongreg
Copy link
Member

@Gongreg Gongreg commented Aug 10, 2017

Issue: rn examples were missing addon knobs examples.

What I did

Added example taken from cra example.

How to test

Try it out.

@tmeasday
Copy link
Member

I don't reckon the duplication is an issue!

Can you update the snapshot? Should be a matter of running npm test -- -u and checking in the snapshot changes.

@Gongreg
Copy link
Member Author

Gongreg commented Aug 16, 2017

@tmeasday, alright, I'll do it tomorrow. :)

Copy link
Member

@danielduan danielduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good to me. The duplication errors are there to help us find redundant code, but this should probably be duplicated.

@ndelangen
Copy link
Member

I fixed a merge-conflict in the package.json

@ndelangen ndelangen changed the base branch from master to release/3.3 August 25, 2017 22:54
@codecov
Copy link

codecov bot commented Aug 26, 2017

Codecov Report

Merging #1636 into release/3.3 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/3.3    #1636   +/-   ##
============================================
  Coverage        21.24%   21.24%           
============================================
  Files              252      252           
  Lines             5695     5695           
  Branches           683      687    +4     
============================================
  Hits              1210     1210           
+ Misses            3958     3938   -20     
- Partials           527      547   +20
Impacted Files Coverage Δ
.../ui/src/modules/ui/components/layout/dimensions.js 15.62% <0%> (ø) ⬆️
addons/knobs/src/components/types/Object.js 5.81% <0%> (ø) ⬆️
lib/ui/src/libs/key_events.js 23.25% <0%> (ø) ⬆️
app/react/src/client/preview/element_check.js 41.17% <0%> (ø) ⬆️
lib/ui/src/modules/ui/libs/hierarchy.js 48.8% <0%> (ø) ⬆️
addons/knobs/src/components/PropField.js 10.86% <0%> (ø) ⬆️
app/react/src/client/preview/error_display.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/libs/filters.js 47.36% <0%> (ø) ⬆️
addons/storyshots/src/require_context.js 0% <0%> (ø) ⬆️
...react-native/src/manager/components/PreviewHelp.js 0% <0%> (ø) ⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90897f8...740cb19. Read the comment docs.

@ndelangen ndelangen self-assigned this Aug 26, 2017
@ndelangen
Copy link
Member

TESTED

@ndelangen ndelangen merged commit 6ac2d69 into release/3.3 Aug 26, 2017
@ndelangen ndelangen deleted the addon-knobs-rn-example branch August 26, 2017 18:40
@shilman shilman mentioned this pull request Aug 31, 2017
@ndelangen ndelangen changed the title [Examples] Added addon-knobs to crna and vanilla react native. Added addon-knobs to crna and vanilla react native. Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants