Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Jest warnings #1744

Merged
merged 2 commits into from
Aug 26, 2017
Merged

Conversation

dangreenisrael
Copy link
Member

@dangreenisrael dangreenisrael commented Aug 26, 2017

Issue: N/A

What I did

I fixed all Jest warnings except one in addons/info/src/index.test.js

No functionality was changed, I just cleaned up some test to make sure that everything marked as .isRequired in propTypes was indeed provided.

All Jest warnings fixed except one in `addons/info/src/index.test.js`
@codecov
Copy link

codecov bot commented Aug 26, 2017

Codecov Report

Merging #1744 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1744      +/-   ##
==========================================
- Coverage   21.18%   21.14%   -0.04%     
==========================================
  Files         252      252              
  Lines        5694     5694              
  Branches      680      686       +6     
==========================================
- Hits         1206     1204       -2     
+ Misses       3981     3956      -25     
- Partials      507      534      +27
Impacted Files Coverage Δ
app/react/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/react/src/server/babel_config.js 0% <0%> (-83.88%) ⬇️
app/react/src/client/preview/client_api.js 85% <0%> (-2.5%) ⬇️
app/vue/src/client/preview/client_api.js 85.1% <0%> (-2.13%) ⬇️
app/react/src/client/preview/element_check.js 41.17% <0%> (ø) ⬆️
.../src/manager/containers/CommentsPanel/dataStore.js 34.78% <0%> (ø) ⬆️
addons/info/src/components/Node.js 38.88% <0%> (ø) ⬆️
addons/info/src/components/PropTable.js 21% <0%> (ø) ⬆️
lib/ui/src/modules/api/configs/init_api.js 40.47% <0%> (ø) ⬆️
addons/info/src/components/PropVal.js 43.15% <0%> (ø) ⬆️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 381d4e8...9707280. Read the comment docs.

@ndelangen
Copy link
Member

What a great first PR!, thank you! Will we be seeing more PRs like this from you? 😍

Copy link
Member

@ndelangen ndelangen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TESTED

@ndelangen ndelangen merged commit e877afc into storybookjs:master Aug 26, 2017
@dangreenisrael
Copy link
Member Author

@ndelangen Thanks for the kind words 😄 . You absolutely will be seeing more of me - I really want to get more into contributing to open source projects and I am really loving storybook.

@dangreenisrael dangreenisrael deleted the fixing-warnings branch August 26, 2017 20:35
@ndelangen
Copy link
Member

If you're not already on there, please join our slack. You can self-invite here: https://now-examples-slackin-nqnzoygycp.now.sh/

If you need any help from me or anyone else in the community that's probably the best place to ask.
I'm always excited to be helping new contributors!

@ndelangen
Copy link
Member

ndelangen commented Aug 27, 2017

If you're into testing, this might be a awesome follow-up:
#1746

You'll instantly be @shilman's best buddy! 😂

@shilman shilman mentioned this pull request Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants