-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Jest warnings #1744
Fixed Jest warnings #1744
Conversation
All Jest warnings fixed except one in `addons/info/src/index.test.js`
Codecov Report
@@ Coverage Diff @@
## master #1744 +/- ##
==========================================
- Coverage 21.18% 21.14% -0.04%
==========================================
Files 252 252
Lines 5694 5694
Branches 680 686 +6
==========================================
- Hits 1206 1204 -2
+ Misses 3981 3956 -25
- Partials 507 534 +27
Continue to review full report at Codecov.
|
What a great first PR!, thank you! Will we be seeing more PRs like this from you? 😍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TESTED
@ndelangen Thanks for the kind words 😄 . You absolutely will be seeing more of me - I really want to get more into contributing to open source projects and I am really loving storybook. |
If you're not already on there, please join our slack. You can self-invite here: https://now-examples-slackin-nqnzoygycp.now.sh/ If you need any help from me or anyone else in the community that's probably the best place to ask. |
Issue: N/A
What I did
I fixed all Jest warnings except one in
addons/info/src/index.test.js
No functionality was changed, I just cleaned up some test to make sure that everything marked as
.isRequired
inpropTypes
was indeed provided.