Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor grammar fixes and clarification to Vue documentation #1756

Merged
merged 1 commit into from
Aug 28, 2017

Conversation

bcass
Copy link
Contributor

@bcass bcass commented Aug 28, 2017

Issue: The page of documentation needed a little cleanup

What I did

Fixed up the documentation a bit.

How to test

Read over the diff and make sure it scans.

Is this testable with jest or storyshots? No

Does this need a new example in the kitchen sink apps? No

Does this need an update to the documentation? N/A

If your answer is yes to any of these, please make sure to include it in your PR.

@codecov
Copy link

codecov bot commented Aug 28, 2017

Codecov Report

Merging #1756 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1756   +/-   ##
=======================================
  Coverage   21.14%   21.14%           
=======================================
  Files         252      252           
  Lines        5694     5694           
  Branches      683      684    +1     
=======================================
  Hits         1204     1204           
+ Misses       3962     3958    -4     
- Partials      528      532    +4
Impacted Files Coverage Δ
app/react/src/server/utils.js 0% <0%> (-32.15%) ⬇️
addons/knobs/src/react/WrapStory.js 12% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_routing.js 28.04% <0%> (ø) ⬆️
lib/ui/src/modules/ui/libs/filters.js 47.36% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_keyevents.js 33.33% <0%> (ø) ⬆️
addons/knobs/src/components/types/Color.js 8% <0%> (ø) ⬆️
...codemod/src/transforms/update-organisation-name.js 40.62% <0%> (ø) ⬆️
lib/ui/src/modules/api/actions/api.js 50.47% <0%> (ø) ⬆️
lib/ui/src/modules/api/configs/init_api.js 40.47% <0%> (ø) ⬆️
addons/storyshots/src/require_context.js 0% <0%> (ø) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e877afc...b7eca1e. Read the comment docs.

@ndelangen ndelangen merged commit 777ce30 into storybookjs:master Aug 28, 2017
@ndelangen
Copy link
Member

Fantastic @bcass !!! Thank you so much for improving Storybook!

I've published these changes to the site!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants