Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1699 Have Stories on each level of hierarchy #1763

Merged
merged 5 commits into from
Aug 30, 2017

Conversation

igor-dv
Copy link
Member

@igor-dv igor-dv commented Aug 29, 2017

Issue: #1699

What I did

Fix #1699

image

@codecov
Copy link

codecov bot commented Aug 29, 2017

Codecov Report

Merging #1763 into release/3.3 will decrease coverage by 0.11%.
The diff coverage is 87.5%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/3.3    #1763      +/-   ##
===============================================
- Coverage        23.12%   23.01%   -0.12%     
===============================================
  Files              253      253              
  Lines             5755     5731      -24     
  Branches           687      682       -5     
===============================================
- Hits              1331     1319      -12     
+ Misses            3935     3919      -16     
- Partials           489      493       +4
Impacted Files Coverage Δ
...mponents/left_panel/stories_tree/tree_node_type.js 0% <ø> (ø) ⬆️
...ponents/left_panel/stories_tree/tree_decorators.js 34.37% <0%> (+1.04%) ⬆️
...les/ui/components/left_panel/stories_tree/index.js 100% <100%> (ø) ⬆️
lib/ui/src/modules/ui/libs/hierarchy.js 50.74% <85.71%> (+1.93%) ⬆️
app/vue/src/server/utils.js 0% <0%> (-32.15%) ⬇️
lib/ui/src/libs/key_events.js 23.25% <0%> (ø) ⬆️
lib/ui/src/modules/ui/libs/filters.js 47.36% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/down_panel.js 23.52% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/menu_item.js 19.14% <0%> (ø) ⬆️
lib/components/src/navigation/menu_link.js 0% <0%> (ø) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdee05a...41d5f8e. Read the comment docs.

@ndelangen
Copy link
Member

@ndelangen ndelangen self-requested a review August 29, 2017 14:00
@igor-dv igor-dv changed the base branch from master to release/3.3 August 29, 2017 14:41
@igor-dv igor-dv added this to the v3.3.0 milestone Aug 29, 2017
Copy link
Member

@ndelangen ndelangen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks good to me.

I tested:
cra-kitchen-sink: ✅
vue-kitchen-sink: ✅ (temp edited a story)
react-native-vanilla: ✅ (temp edited a story)

All examples kinda need some reorganising, for sure. But that's out of scope for this PR.

I'm super impressed by how fast you made this happen @igor-dv ! 💥

Copy link
Member

@Hypnosphi Hypnosphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndelangen ndelangen merged commit 12cd9c3 into release/3.3 Aug 30, 2017
@ndelangen ndelangen deleted the 1699-have-stories-on-each-level-of-hierarchy branch August 30, 2017 21:03
@shilman shilman mentioned this pull request Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants