Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add carbon to examples page #1764

Merged
merged 1 commit into from
Aug 29, 2017
Merged

Conversation

tw15egan
Copy link
Contributor

What I did

Added Carbon Design System to list of example pages

How to test

Check example page

Thanks to @ndelangen for the suggestion. Let me know if any changes need to be made 👍

@codecov
Copy link

codecov bot commented Aug 29, 2017

Codecov Report

Merging #1764 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1764   +/-   ##
=======================================
  Coverage   21.14%   21.14%           
=======================================
  Files         252      252           
  Lines        5694     5694           
  Branches      684      690    +6     
=======================================
  Hits         1204     1204           
+ Misses       3975     3959   -16     
- Partials      515      531   +16
Impacted Files Coverage Δ
app/react-native/src/bin/storybook-start.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Select.js 7.81% <0%> (ø) ⬆️
app/react/src/client/preview/error_display.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Object.js 5.81% <0%> (ø) ⬆️
lib/ui/src/modules/api/actions/api.js 50.47% <0%> (ø) ⬆️
addons/knobs/src/components/PropField.js 10.86% <0%> (ø) ⬆️
lib/components/src/navigation/menu_link.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/libs/filters.js 47.36% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/layout/usplit.js 38.7% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-build.js 0% <0%> (ø) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 326acbc...d95f279. Read the comment docs.

@ndelangen
Copy link
Member

Tested

@ndelangen ndelangen merged commit 3c02e46 into storybookjs:master Aug 29, 2017
@ndelangen
Copy link
Member

I'll publish it when i get home

@tw15egan
Copy link
Contributor Author

Thanks!

@shilman shilman mentioned this pull request Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants