Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing typo on VueJS withNotes Example #1787

Merged
merged 2 commits into from
Sep 2, 2017
Merged

Fixing typo on VueJS withNotes Example #1787

merged 2 commits into from
Sep 2, 2017

Conversation

Ethaan
Copy link
Contributor

@Ethaan Ethaan commented Sep 2, 2017

Fixing wrong param passed to withNotes method.

Issue:

#1766

What I did

rename param notes => text

How to test

simple run yarn storybook and now the example, and the example Addon Notes => Note with HTML should be working

Fixing wrong param passed to withNotes method.
@codecov
Copy link

codecov bot commented Sep 2, 2017

Codecov Report

Merging #1787 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1787   +/-   ##
=======================================
  Coverage   21.14%   21.14%           
=======================================
  Files         252      252           
  Lines        5693     5693           
  Branches      682      682           
=======================================
  Hits         1204     1204           
+ Misses       3991     3987    -4     
- Partials      498      502    +4
Impacted Files Coverage Δ
app/vue/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/vue/src/server/babel_config.js 0% <0%> (-83.88%) ⬇️
addons/storyshots/src/storybook-channel-mock.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_routing.js 28.04% <0%> (ø) ⬆️
...rc/modules/ui/components/left_panel/text_filter.js 30.98% <0%> (ø) ⬆️
addons/knobs/src/components/PropForm.js 8.51% <0%> (ø) ⬆️
addons/knobs/src/components/PropField.js 10.86% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-build.js 0% <0%> (ø) ⬆️
addons/events/src/components/Event.js 0% <0%> (ø) ⬆️
addons/knobs/src/KnobStore.js 6.81% <0%> (ø) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b474cbd...512e764. Read the comment docs.

@Hypnosphi Hypnosphi self-assigned this Sep 2, 2017
@Hypnosphi Hypnosphi self-requested a review September 2, 2017 22:35
@Hypnosphi
Copy link
Member

Hypnosphi commented Sep 2, 2017

Nice catch! Please fix this usage as well (3.2 came with "text" option name from the start)

@Ethaan
Copy link
Contributor Author

Ethaan commented Sep 2, 2017

@Hypnosphi done! =D

Copy link
Member

@Hypnosphi Hypnosphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hypnosphi Hypnosphi merged commit f4b650e into storybookjs:master Sep 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants