Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: A more human-friendly message for undetected project types #1825

Merged
merged 2 commits into from
Sep 9, 2017

Conversation

Hypnosphi
Copy link
Member

Issue: #475

This is a replacement for #1647, restricted to improving the console output only

@codecov
Copy link

codecov bot commented Sep 9, 2017

Codecov Report

Merging #1825 into release/3.3 will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/3.3    #1825      +/-   ##
===============================================
- Coverage        22.45%   22.45%   -0.01%     
===============================================
  Files              321      321              
  Lines             6279     6280       +1     
  Branches           786      777       -9     
===============================================
  Hits              1410     1410              
- Misses            4281     4284       +3     
+ Partials           588      586       -2
Impacted Files Coverage Δ
lib/cli/bin/generate.js 0% <0%> (ø) ⬆️
addons/info/src/components/PropVal.js 41.41% <0%> (ø) ⬆️
addons/knobs/src/components/PropField.js 10.86% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-start.js 0% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/layout/dimensions.js 15.62% <0%> (ø) ⬆️
addons/knobs/src/components/types/Select.js 7.93% <0%> (ø) ⬆️
addons/storyshots/src/storybook-channel-mock.js 22.22% <0%> (ø) ⬆️
...react-native/src/manager/components/PreviewHelp.js 0% <0%> (ø) ⬆️
...res__/update-addon-info/update-addon-info.input.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/PropForm.js 8.51% <0%> (ø) ⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cdb906...f9590dc. Read the comment docs.

@Hypnosphi Hypnosphi added cli maintenance User-facing maintenance tasks labels Sep 9, 2017
@Hypnosphi Hypnosphi merged commit 2a27cf6 into release/3.3 Sep 9, 2017
@Hypnosphi Hypnosphi deleted the undetected branch September 9, 2017 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants