Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Lint css, html, json, md, mdx, yml files #18735

Merged
merged 3 commits into from
Jul 25, 2022
Merged

Conversation

ndelangen
Copy link
Member

I found out you can lint these files pretty fast via a command, and also pre-commit

more consistency = good

@nx-cloud
Copy link

nx-cloud bot commented Jul 18, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c7466f5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@ndelangen ndelangen changed the base branch from next to future/base July 18, 2022 18:28
@ndelangen ndelangen self-assigned this Jul 18, 2022
@ndelangen ndelangen added the maintenance User-facing maintenance tasks label Jul 18, 2022
@shilman shilman changed the title Future - improve linting : lint css,html,json,md,mdx,yml files Build: Lint css, html, json, md, mdx, yml files Jul 19, 2022
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, tho I question the style choice on MDX

docs/snippets/angular/badge-story.mdx.mdx Outdated Show resolved Hide resolved
@ndelangen
Copy link
Member Author

related:
#18556

Base automatically changed from future/base to next July 25, 2022 10:37
@ndelangen ndelangen force-pushed the future/improve-linting branch from c7466f5 to d08c11c Compare July 25, 2022 16:51
@ndelangen
Copy link
Member Author

I removed the mdx linting for now.

@ndelangen ndelangen merged commit 06a88f8 into next Jul 25, 2022
@ndelangen ndelangen deleted the future/improve-linting branch July 25, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants