Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build lib/addons with ts-up #18805

Merged
merged 8 commits into from
Sep 27, 2022

Conversation

abdlqader
Copy link

Issue: #18732

What I did

Changed addons in lib to be compiled by the bundler ( ts-up )

How to test

  • [ YES ] Is this testable with Jest or Chromatic screenshots? Testable by the original tests
  • [ NO ] Does this need a new example in the kitchen sink apps?
  • [ NO ] Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@ndelangen ndelangen changed the title [CHANGED] lib/addons changed to tsup lib/addons changed to tsup Aug 23, 2022
@ndelangen ndelangen added the maintenance User-facing maintenance tasks label Aug 23, 2022
@ndelangen ndelangen changed the title lib/addons changed to tsup Build lib/addons with ts-up Aug 25, 2022
@IanVS IanVS force-pushed the feat/lib-addons-to-tsup branch 2 times, most recently from 71009f9 to 0cf63cd Compare September 27, 2022 01:51
@IanVS IanVS force-pushed the feat/lib-addons-to-tsup branch from 0cf63cd to 6b8a0bb Compare September 27, 2022 01:56
@IanVS IanVS requested a review from ndelangen September 27, 2022 02:43
@IanVS
Copy link
Member

IanVS commented Sep 27, 2022

@ndelangen I got this passing by adding /// <reference types="webpack-env" /> to the addons that are using module.hot.decline(), since that's a webpack feature.

Which makes me wonder, do we need these to also call import.meta.hot.decline() for the vite builder?

@ndelangen
Copy link
Member

Yes that would make sense for any files that are referenced from stories

@ndelangen ndelangen merged commit c548f34 into storybookjs:next Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants