-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build lib/addons with ts-up #18805
Merged
ndelangen
merged 8 commits into
storybookjs:next
from
abdlqader:feat/lib-addons-to-tsup
Sep 27, 2022
Merged
Build lib/addons with ts-up #18805
ndelangen
merged 8 commits into
storybookjs:next
from
abdlqader:feat/lib-addons-to-tsup
Sep 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
reviewed
Aug 1, 2022
ndelangen
changed the title
[CHANGED] lib/addons changed to tsup
lib/addons changed to tsup
Aug 23, 2022
IanVS
force-pushed
the
feat/lib-addons-to-tsup
branch
2 times, most recently
from
September 27, 2022 01:51
71009f9
to
0cf63cd
Compare
# Conflicts: # code/lib/addons/package.json
# Conflicts: # code/lib/addons/package.json
IanVS
force-pushed
the
feat/lib-addons-to-tsup
branch
from
September 27, 2022 01:56
0cf63cd
to
6b8a0bb
Compare
@ndelangen I got this passing by adding Which makes me wonder, do we need these to also call |
Yes that would make sense for any files that are referenced from stories |
ndelangen
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #18732
What I did
Changed addons in lib to be compiled by the bundler ( ts-up )
How to test
If your answer is yes to any of these, please make sure to include it in your PR.