Exit yarn bootstrap with nonzero code if failed #19089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # scripts/bootstrap.js
IanVS
force-pushed
the
bootstrap-exit-code
branch
from
9f6d53f to
1a86d27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: CI fails in a non-obvious way if
yarn bootstrap --buildfailsWhat I did
When one or more of the steps
yarn bootstrap --buildfails, the exit code was0, so CI doesn't know anything went wrong, and then random-seeming steps further on in the process fail. For an example of this, see https://app.circleci.com/pipelines/github/storybookjs/storybook/28842/workflows/d3da014b-c899-4113-890d-80141f32fc11. You'll note that the build step is green, but should have failed.So, this change returns the
spawnSyncresult back to the spot where it's being called, then we check for a non-zero status code andprocess.exit()with that code if necessary.How to test
Make a change that causes
yarn bootstrap --buildto fail, thenecho $?. You should see a non-zero number after this PR, whereas before it was0.