Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add polyfills to fix addon-actions in IE11 #1917

Merged
merged 2 commits into from
Sep 30, 2017
Merged

Conversation

Hypnosphi
Copy link
Member

This is needed because react-inspector uses Symbol and Array#@@iterator

How to test

Open cra-kitchen-sink in IE11, navigate to Button/with text, press the button.

@codecov
Copy link

codecov bot commented Sep 29, 2017

Codecov Report

Merging #1917 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1917      +/-   ##
=========================================
- Coverage   21.31%   21.3%   -0.02%     
=========================================
  Files         257     257              
  Lines        5737    5741       +4     
  Branches      697     682      -15     
=========================================
  Hits         1223    1223              
- Misses       3975    4015      +40     
+ Partials      539     503      -36
Impacted Files Coverage Δ
app/vue/src/server/config/polyfills.js 0% <0%> (ø) ⬆️
app/react/src/server/config/polyfills.js 0% <0%> (ø) ⬆️
...rc/modules/ui/components/left_panel/text_filter.js 30.98% <0%> (ø) ⬆️
lib/ui/src/modules/shortcuts/actions/shortcuts.js 6.25% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_routing.js 28.04% <0%> (ø) ⬆️
addons/knobs/src/KnobStore.js 6.81% <0%> (ø) ⬆️
...res__/update-addon-info/update-addon-info.input.js 0% <0%> (ø) ⬆️
addons/info/src/components/markdown/code.js 24.13% <0%> (ø) ⬆️
app/react/src/client/preview/error_display.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/routes.js 0% <0%> (ø) ⬆️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 928166c...0cb9696. Read the comment docs.

@ndelangen ndelangen merged commit 565099f into master Sep 30, 2017
@ndelangen ndelangen deleted the array-iterator-polyfill branch September 30, 2017 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants