-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix prepare bundle on Windows #19243
Fix prepare bundle on Windows #19243
Conversation
bdf8ee7
to
7bf87d3
Compare
@joshwooding thank you for the contribution! Why are absolute paths a problem? We're using Might be a bug in tsup rather.? Because of the fact we're running these scripts in multiple working directories, it's easy to get mixed up. |
7bf87d3
to
6cc0971
Compare
Thanks @ndelangen after some digging an alternative is to replace the windows path separators with Linux ones. Arguably the fix should belong in tsup but making this change unblocks us for now. |
I can't get the CI to pass. I tried a few times. I don't get why it's failing either. 😢 |
Issue:
What I did
Stopped the entries being passed into tsup being made into absolute paths.
This fixed things for me locally but looking at the tsup docs entry always contains relative files:
How to test
If your answer is yes to any of these, please make sure to include it in your PR.