Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: source-loader lib migrated to use modern build tool #19313

Merged
merged 15 commits into from
Oct 5, 2022
Merged

Update: source-loader lib migrated to use modern build tool #19313

merged 15 commits into from
Oct 5, 2022

Conversation

shariqx5
Copy link
Contributor

@shariqx5 shariqx5 commented Oct 1, 2022 •
edited by IanVS
Loading

Issue:

Reference: #18732

What I did

Use tsup to build @storybook/source-loader

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@shariqx5
Copy link
Contributor Author

shariqx5 commented Oct 2, 2022 •
edited
Loading

Call for help: Migrating to modern build tool : TSUP #18732

@shariqx5
Copy link
Contributor Author

shariqx5 commented Oct 2, 2022

@ndelangen & @IanVS, Would you mind reviewing this PR? I have fixed most of the failing tests, but still, a few are failing.

@IanVS IanVS added the maintenance User-facing maintenance tasks label Oct 2, 2022
@IanVS IanVS mentioned this pull request Oct 2, 2022
Closed
IanVS
IanVS approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@IanVS IanVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@shariqx5
Copy link
Contributor Author

shariqx5 commented Oct 3, 2022

Unable to merge the branch, it says You are not authorized to merge. What could be the issue @IanVS ?

@ndelangen ndelangen self-assigned this Oct 3, 2022
@ndelangen ndelangen added maintenance User-facing maintenance tasks build Internal-facing build tooling & test updates and removed maintenance User-facing maintenance tasks labels Oct 4, 2022
@shariqx5
Copy link
Contributor Author

shariqx5 commented Oct 5, 2022

I'm not authorized to merge this 😞 Can you give me permission @ndelangen?

@ndelangen
Copy link
Member

@shariqx5 you have an invite to the org 🎊

@ndelangen
Copy link
Member

Do we have this addon used anywhere still? I'd like to check if it actually still functions. I'm not aware of any tests that cover this package.

@ndelangen ndelangen added maintenance User-facing maintenance tasks and removed build Internal-facing build tooling & test updates labels Oct 5, 2022
@ndelangen ndelangen merged commit 24ee6b2 into storybookjs:next Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanVS IanVS IanVS approved these changes

@ndelangen ndelangen ndelangen approved these changes

Assignees

@ndelangen ndelangen

Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shariqx5 @ndelangen @IanVS