-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue2: Improve CSF3 types #19603
Merged
Merged
Vue2: Improve CSF3 types #19603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmeasday
approved these changes
Oct 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The tests are going to stand us in very good stead!
shilman
approved these changes
Oct 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This PR provides improved type safety for Vue2 stories (similar to what we changed to React, Svelte and Vue3) but requires vue-tsc instead of tsc (And the Volar VS Code extension for editor support):
https://marketplace.visualstudio.com/items?itemName=Vue.vscode-typescript-vue-plugin
To unlock the full potential of this PR, TS 4.9 is needed, for the new
satisfies
operator. But, this also improves the types for TS<4.9 users.Typesafe args
We changed
StoryObj
andMeta
to increase type safety for when the user provides args partially in meta.Considering a Component like this:
It is valid to provide args like this:
While it is invalid to forget an arg, in either meta or the story:
Changed Meta to make sure both a Component, as the Props of the component can be used:
Typesafe decorators/loaders
Decorators now accept a new generic arg argument to be specified:
And the type of meta/story will check if this arg is part of the generic type:
I also fixed some typescript issues in other files in this package.
How to test
You can test it by running:
yarn nx run @storybook/vue:check