Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tags to story and index #19625

Merged
merged 17 commits into from
Oct 27, 2022
Merged

Add tags to story and index #19625

merged 17 commits into from
Oct 27, 2022

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Oct 26, 2022 •
edited
Loading

What I did

  • Implemented tags at story + component level, combine them into the story context in prepareStory & friends.
  • Add a 'story' tag automatically to all stories.
  • Add tags to the story index generated in v6 mode
  • Add tags to the story index generated in v7 mode (blocked on CSF tools)

How to test

  • Unit tests
  • Tags story
  • No, this is undocumented for now.

@tmeasday tmeasday requested a review from shilman October 26, 2022 05:44
@tmeasday tmeasday mentioned this pull request Oct 26, 2022
Merged
3 tasks
@tmeasday tmeasday marked this pull request as ready for review October 26, 2022 06:57
shilman
shilman approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! 🤩

@tmeasday tmeasday merged commit cabf72e into next Oct 27, 2022
@tmeasday tmeasday deleted the tom/sb-829-add-story-tags-to-the-index-index branch October 27, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees
No one assigned
Labels
core feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmeasday @shilman